Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tweak/plugin header updates #196

Open
wants to merge 7 commits into
base: main
Choose a base branch
from
Open

Conversation

dpanta94
Copy link

All Submissions:

  • Does your code follow the Extendables standards?
  • Have you written new tests for your changes, as applicable?
  • Have you successfully run tests with your changes locally?

Changes proposed in this Pull Request:

Adds 3 new headers to every Request to the Amazon Pay API.

How to test the changes in this Pull Request:

  1. Amazon Pay API requests should include the following extra headers.
    x-amz-pay-platform-version set to active WooCommerce's version
    x-amz-pay-integrator-version set to active Amazon Pay for WooCommerce plugin's version
    x-amz-pay-integrator-id set to the SP's (Solution Provider) ID.

Other information:

  • Have you checked to ensure there aren't other open Pull Requests for the same update/change?

Changelog entry

Add - New Amazon Pay Platform related Headers

@dpanta94 dpanta94 self-assigned this Mar 28, 2023
@dpanta94
Copy link
Author

related feature https://app.clickup.com/t/85zrjngmt

Copy link

@gen4ik-saucal gen4ik-saucal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I do not like any actions inside a method call, so my suggestion is to move array_merge(headers) to a separate line. Other than that looks good.

@dpanta94
Copy link
Author

dpanta94 commented Mar 28, 2023

Updated @gen4ik-saucal according to your comment! Thank you!

@dpanta94 dpanta94 marked this pull request as ready for review April 26, 2023 08:16
@dpanta94
Copy link
Author

Made one more commit here @gen4ik-saucal, if you could check.

Copy link

@gen4ik-saucal gen4ik-saucal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The codewise looks good. Good to go 🚀

@dpanta94 dpanta94 removed their assignment Oct 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants