-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Tweak/plugin header updates #196
base: main
Are you sure you want to change the base?
Conversation
related feature https://app.clickup.com/t/85zrjngmt |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I do not like any actions inside a method call, so my suggestion is to move array_merge(headers) to a separate line. Other than that looks good.
Updated @gen4ik-saucal according to your comment! Thank you! |
Made one more commit here @gen4ik-saucal, if you could check. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The codewise looks good. Good to go 🚀
All Submissions:
Changes proposed in this Pull Request:
Adds 3 new headers to every Request to the Amazon Pay API.
How to test the changes in this Pull Request:
x-amz-pay-platform-version
set to active WooCommerce's versionx-amz-pay-integrator-version
set to active Amazon Pay for WooCommerce plugin's versionx-amz-pay-integrator-id
set to the SP's (Solution Provider) ID.Other information:
Changelog entry