Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Drop Apache commons-io in favor of plain Java API #221

Merged

Conversation

valfirst
Copy link
Contributor

No description provided.

@codecov-commenter
Copy link

Codecov Report

Attention: 1 lines in your changes are missing coverage. Please review.

Comparison is base (b92b916) 60.69% compared to head (8360151) 60.62%.

❗ Current head 8360151 differs from pull request most recent head 0fdc07a. Consider uploading reports for the commit 0fdc07a to get more accurate results

Files Patch % Lines
...elabs/ci/sauceconnect/SauceConnectFourManager.java 75.00% 1 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##               main     #221      +/-   ##
============================================
- Coverage     60.69%   60.62%   -0.07%     
- Complexity      217      220       +3     
============================================
  Files            12       12              
  Lines          1099     1092       -7     
  Branches        165      165              
============================================
- Hits            667      662       -5     
+ Misses          378      376       -2     
  Partials         54       54              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@diemol diemol left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you, @valfirst!

@diemol diemol merged commit bc41a54 into saucelabs:main Nov 27, 2023
3 checks passed
@valfirst valfirst deleted the drop-apache-commons-io-in-favor-of-plain-java branch November 28, 2023 09:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants