Alloc a single array for all planar stuff. #66
Closed
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR optimizes
swscale
in two ways:Make sure that we allocate the right amount of memory for all planes.
We were not taking sub-sampling into account when allocating planes, resulting in memory allocations that were too big.
Allocate all planes in a single memory region
This makes it possible to e.g. pass a single pointer to APIs that expect planar formats to be a single memory pointer without having to do copies
With liquidsoap, I noticed a serious drop in memory used during video operations:
Before
After
The relevant part is the private memory.