Add option to unwrap array of hashes #52
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for submitting this pull request @TiteiKo! I don't recall seeing any pull requests for this before, but November feels like it was ages ago at this point. I'm more than happy to merge this, since it all looks very reasonable, but I'm surprised this isn't the default behavior. SOAP is always very surprising, so I can imagine that maybe, at some point, someone needed an array of hashes to work this way. |
tjarratt
added a commit
that referenced
this pull request
Mar 11, 2015
Add option to unwrap array of hashes
|
Just released this as Gyoku v1.2.3 -- let me know if there's anything more I can do to help. Dreadfully sorry that I never responded to your initial issue on Savon, but I'm very glad that you came back and contributed to the project! |
johankok
added a commit
to johankok/gyoku
that referenced
this pull request
Apr 22, 2015
mahemoff
added a commit
to mahemoff/gyoku
that referenced
this pull request
Dec 24, 2015
Array serialization in Gyoku confused me until I discovered savonrb#52 and looked at the test case. This doco should help. Note it doesn't document the further enhancement in savonrb#54, which is not yet merged.
mahemoff
added a commit
to mahemoff/gyoku
that referenced
this pull request
Dec 24, 2015
Array serialization in Gyoku confused me until I discovered savonrb#52 and looked at the test case. This doco should help. Note it doesn't document the further enhancement in savonrb#54, which is not yet merged.
mahemoff
added a commit
to mahemoff/gyoku
that referenced
this pull request
Dec 24, 2015
Array serialization in Gyoku confused me until I discovered savonrb#52 and looked at the test case. This doco should help. Note it doesn't document the further enhancement in savonrb#54, which is not yet merged.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi
So, I was having a "small" issue with savon savonrb/savon#672 that was in fact a Gyoku issue, already discussed here : #48
Turns out, @stgwilli did quite an awesome job on that last november and (correct me if I'm wrong, but I did check), never pull requested it.
To make it simple, it allows array of hashes to be correctly formatted, without breaking any previous behaviour, as it is by adding an option (unwrap).
It would be really nice to have this alternative, I'm pretty sure I'm not the only one who will have to switch to nokogiri otherwise (and that would pain me a great deal, as Gyoku is really great)