-
Notifications
You must be signed in to change notification settings - Fork 615
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Multiple namespaces #389
Multiple namespaces #389
Conversation
i need specs for that. please add your wsdl as a fixture. |
I added the WSDL that I am using as |
yes. that an specs (tests) based on your wsdl which confirm that with your change, |
The WSDL that I'm using requires authentication. It's not a free services so we can't use a fake account for testing. What do you think is the best way to proceed? |
ok, so i was checking out your branch and ran the specs before writing a spec for this bundle exec rspec since these failures are related to the changes introduced by this pull request, they need regarding the specs for your change, savon comes with a simple server to mock external |
btw. debugging those integration specs should be really easy. |
this should be fixed with v2.3.0 /cc #481. |
Convert the path to each operation to snakecase in
builder#use_namespace
.It appears that the format of these strings were always lower camel case, whereas
@operation_name
is in snakecase. This would result in no matches being found when there were multiple namespaces. Converting the string to snakecase (hopefully) resolves this issue.The same fix is applied to messages with arguments.
Related to: Issue #384