Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Multiple namespaces #389

Closed
wants to merge 3 commits into from
Closed

Multiple namespaces #389

wants to merge 3 commits into from

Conversation

ryanaghdam
Copy link

Convert the path to each operation to snakecase in builder#use_namespace.

It appears that the format of these strings were always lower camel case, whereas @operation_name is in snakecase. This would result in no matches being found when there were multiple namespaces. Converting the string to snakecase (hopefully) resolves this issue.

The same fix is applied to messages with arguments.

Related to: Issue #384

@rubiii
Copy link
Contributor

rubiii commented Feb 7, 2013

i need specs for that. please add your wsdl as a fixture.

@ryanaghdam
Copy link
Author

I added the WSDL that I am using as compex.wsdl. Is that what you wanted?

@rubiii
Copy link
Contributor

rubiii commented Feb 8, 2013

yes. that an specs (tests) based on your wsdl which confirm that with your change,
savon uses the correct namespace identifier.

@ryanaghdam
Copy link
Author

The WSDL that I'm using requires authentication. It's not a free services so we can't use a fake account for testing. What do you think is the best way to proceed?

@rubiii
Copy link
Contributor

rubiii commented Feb 8, 2013

ok, so i was checking out your branch and ran the specs before writing a spec for this
and noticed that the integration tests are failing. those tests are not run on travis, because
we can't rely on the services to always be there, but they can be run via:

bundle exec rspec

since these failures are related to the changes introduced by this pull request, they need
to be fixed before anything else.

regarding the specs for your change, savon comes with a simple server to mock external
services that can be used to return a wsdl to simulate a service. here's an example using
where were sending a wsdl fixture and the server simply repeats the request.

@rubiii
Copy link
Contributor

rubiii commented Feb 8, 2013

btw. debugging those integration specs should be really easy.
you can simply enable logging, set the pretty_print_xml option and validate the namespaces.

@rubiii
Copy link
Contributor

rubiii commented Jul 27, 2013

this should be fixed with v2.3.0 /cc #481.

@rubiii rubiii closed this Jul 27, 2013
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants