Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Only set port_message_ns_id and port_message_type if a port_type_input is found. #12

Closed
wants to merge 2 commits into from
Closed

Conversation

cschiewek
Copy link

This fixes the parsing of the WSDL file I linked in #11.

@rubiii
Copy link
Contributor

rubiii commented Jul 13, 2012

can you add specs based on your wsdl please?

@cschiewek
Copy link
Author

I've added a wsdl without port type and a spec that ensures that operations are correctly parsed even if the WSDL is missing port_type.

@rubiii
Copy link
Contributor

rubiii commented Jul 25, 2012

may i ask where you got that wsdl from? because it looks like it's not valid. soapUI doesn't know what to do with it and by looking at it, i have no idea how any tool could parse it. the name which refers from the service to the binding seems wrong and the fact that it's missing a portType is really weird.

@cschiewek
Copy link
Author

I copy and pasted it from an existing WSDL in the fixtures directory, and just removed the portType. I agree it's strange, but missing portType seems to be a fairly common occurrence for SOAP services generated using .NET WCF. I had difficulties finding examples of WSDL documents without portType, but I'm open to suggestions.

@rubiii
Copy link
Contributor

rubiii commented Jul 25, 2012

my suggestion would be to not mess with wsdl documents and actually use a real example,
because the test suite already contains enough fake fixtures and we can't continue like that.

the current parser only looks at parts of the wsdl and doesn't connect services to bindings
to portTypes to messages, etc. but the new parser i'm working on right now is doing that
and it is not going to work with fake fixtures.

@rubiii rubiii closed this Jul 26, 2012
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants