Trib 263 #100
Merged
Trib 263 #100
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
function to details-page.ts that prints a message in console.
haxwell
requested changes
Apr 28, 2024
| @@ -2,6 +2,7 @@ import {Component, OnInit} from "@angular/core"; | |||
| import {ActivatedRoute} from "@angular/router"; | |||
| import { Router} from "@angular/router"; | |||
| import { ConnectModelService } from '../_services/connect.model.service'; | |||
| import { AlertService } from "../_services/alert/alert.service"; | |||
There was a problem hiding this comment.
You'll want to import the original alert.service, rather than making a copy of it.
haxwell
reviewed
Apr 28, 2024
src/app/pages/connect-page/connection-details/connection-details.page.ts
Show resolved
Hide resolved
|
|
||
| onRemoveBtnClick() { | ||
| let self = this; | ||
| this._alertService.show({ |
There was a problem hiding this comment.
Use proper indenting. Look at other code/classes to see how it's done in other classes.
|
My first free day I will work on making the appointed changes.
…On Sunday, April 28th, 2024 at 3:32 PM, Johnathan James ***@***.***> wrote:
@haxwell commented on this pull request.
---------------------------------------------------------------
In [src/app/pages/connect-page/connection-details/connection-details.page.ts](#100 (comment)):
> @@ -29,7 +31,19 @@ export class ConnectionDetailsPage implements OnInit{
// self.navigateTo('/list-connections');
// }
// }
-
+ onRemoveBtnClick() {
There should be a blank line between any class level functions, and any comments that do not apply to what follows them (in this case, the commented out method/function (ending at line 33) does not relate to the onRemoveBtnClick() function. Add a blank line.
---------------------------------------------------------------
In [src/app/pages/connect-page/connection-details/connection-details.page.ts](#100 (comment)):
> @@ -29,7 +31,19 @@ export class ConnectionDetailsPage implements OnInit{
// self.navigateTo('/list-connections');
// }
// }
-
+ onRemoveBtnClick() {
+ let self = this;
+ this._alertService.show({
Use proper indenting. Look at other code/classes to see how it's done in other classes.
—
Reply to this email directly, [view it on GitHub](#100 (review)), or [unsubscribe](https://github.com/notifications/unsubscribe-auth/BIB2IF4NCK6CXWY64ABKQYDY7VMGPAVCNFSM6AAAAABG3RYDHGVHI2DSMVQWIX3LMV43YUDVNRWFEZLROVSXG5CSMV3GSZLXHMZDAMRXGM2DENZZGU).
You are receiving this because you authored the thread.Message ID: ***@***.***>
|
Closed
|
This looks good! Clear up the conflict there, and we can merge! |
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added an alert to the "remove" button. To do this I had to copy the "alert" folder from src/app/_services and paste it into src/app/pages/connect-page/_services. Also I had to modify the "onRemoveBtnClick" function in connection-details.page.ts. I also added a type to connection-details.page.ts and imported from "../_services/alert/alert.service."