Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replaced call to subscribe(func, func) with subscribe({next: func, er… #143

Merged
merged 5 commits into from
Sep 10, 2024

Conversation

haxwell
Copy link
Contributor

@haxwell haxwell commented Aug 29, 2024

Replaced call to subscribe(func, func) with subscribe({next: func, error: func})

@haxwell haxwell requested a review from a team August 29, 2024 23:15
@haxwell haxwell added the technical debt Stuff we've been meaning to fix label Aug 30, 2024
@haxwell
Copy link
Contributor Author

haxwell commented Sep 10, 2024

This PR actually just changes the github ci upload artifacts library to v4. The original API tech debt issue was resolved elsewhere. nothing to see here.

@haxwell haxwell merged commit 3b1ca6c into feature/connect-page Sep 10, 2024
1 check passed
@haxwell haxwell deleted the fix-api-call-deprecation branch September 10, 2024 23:07
@haxwell haxwell restored the fix-api-call-deprecation branch November 19, 2024 14:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
technical debt Stuff we've been meaning to fix
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

1 participant