Trib -128: Review approve attributes #62
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…-page Feature/review attributes page
albkappil
changed the title
haxwell
requested changes
Sep 5, 2023
src/app/pages/review-attributes/_services/review-attributes.api.service.ts
Outdated
Show resolved
Hide resolved
src/app/pages/review-attributes/_services/review-attributes.model.service.ts
Outdated
Show resolved
Hide resolved
src/app/pages/review-attributes/_services/review-attributes.model.service.ts
Outdated
Show resolved
Hide resolved
haxwell
requested changes
Sep 13, 2023
…lbkappil/tribe-app-frontend into review-approve-attributes
This reverts commit e920c5c.
haxwell
requested changes
Sep 17, 2023
src/app/pages/review-attributes/_services/review-attributes.api.service.ts
Outdated
Show resolved
Hide resolved
haxwell
requested changes
Oct 4, 2023
haxwell
requested changes
Oct 26, 2023
src/app/pages/review-attributes/_services/review-attributes.model.service.ts
Outdated
Show resolved
Hide resolved
src/app/pages/review-attributes/_services/review-attributes.model.service.ts
Outdated
Show resolved
Hide resolved
src/app/pages/review-attributes/_services/review-attributes.model.service.ts
Outdated
Show resolved
Hide resolved
|
Also, package-lock.json should not be included in the PR. |
|
|
I deleted package-lock.json from PR |
albkappil
force-pushed
the
review-approve-attributes
branch
from
397c281 to
7e206bc
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Here is the Frontend Review attributes approving phrase.
https://mockprogrammingjob.atlassian.net/browse/TRIB-128