Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: generate Angular classes and tests #1

Merged

Conversation

DavideMininni-Fincons
Copy link
Contributor

@DavideMininni-Fincons DavideMininni-Fincons commented Dec 18, 2024

Angular classes and tests generation

Draft PR waiting for sbb-design-systems/lyne-components#3299 to be merged

Tests and build scripts are not working, maybe it needs some improvement in the Angular configuration

Copy link
Contributor

@kyubisation kyubisation left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍
Amazing work!

@github-actions github-actions bot added the pr: lead review approved Pull request has been approved by a lead review label Jan 8, 2025
@DavideMininni-Fincons DavideMininni-Fincons merged commit deee84c into feat/angular-wrapper Jan 8, 2025
12 checks passed
@github-actions github-actions bot added the pr: peer review required A peer review is required for this pull request label Jan 8, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pr: lead review approved Pull request has been approved by a lead review pr: peer review required A peer review is required for this pull request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants