fix: fix review

sbb-design-systems · Nov 21, 2024 · 6a5623b · 6a5623b
1 parent 8551db6
commit 6a5623b
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 4 deletions.
diff --git a/src/elements/time-input/time-input.spec.ts b/src/elements/time-input/time-input.spec.ts
@@ -216,7 +216,7 @@ describe(`sbb-time-input`, () => {
     await waitForLitRender(element);
     expect(input.value).to.be.equal('15:00');
 
-    const dateCalculated = element.valueAsDate.getTime();
+    const dateCalculated = element.valueAsDate!.getTime();
     expect(new Date(dateCalculated).getHours()).to.be.equal(date.getHours());
     expect(new Date(dateCalculated).getMinutes()).to.be.equal(date.getMinutes());
   });

diff --git a/src/elements/time-input/time-input.ts b/src/elements/time-input/time-input.ts
@@ -46,9 +46,11 @@ class SbbTimeInputElement extends LitElement {
   }
   private _input: string | HTMLElement | null = null;
 
+  @state() private accessor _inputElement: HTMLInputElement | null = null;
+
   /** Formats the current input's value as date. */
   @property({ attribute: false })
-  public set valueAsDate(date: SbbDateLike) {
+  public set valueAsDate(date: SbbDateLike | null) {
     if (!date || !this._inputElement) {
       return;
     }
@@ -67,8 +69,6 @@ class SbbTimeInputElement extends LitElement {
     return this._formatValueAsDate(this._parseInput(this._inputElement?.value)) ?? null;
   }
 
-  @state() private _inputElement: HTMLInputElement | null;
-
   /**
    * @deprecated only used for React. Will probably be removed once React 19 is available.
    */