Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build: fix logic for SSR in React wrapper #3174

Merged
merged 3 commits into from
Oct 28, 2024

Conversation

DavideMininni-Fincons
Copy link
Contributor

The introduction of @slotstate broke #2306 due to the missing call of new SbbSloteStateController, so a check on the class decorator has been added with the same logic.

Copy link
Contributor

@TomMenga TomMenga left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@github-actions github-actions bot added pr: peer review approved Pull request has been approved by a peer review and removed pr: peer review required A peer review is required for this pull request labels Oct 28, 2024
Copy link
Contributor

@jeripeierSBB jeripeierSBB left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. thank you

@github-actions github-actions bot added the pr: lead review approved Pull request has been approved by a lead review label Oct 28, 2024
@DavideMininni-Fincons DavideMininni-Fincons merged commit 7beee1a into main Oct 28, 2024
30 checks passed
@DavideMininni-Fincons DavideMininni-Fincons deleted the build/typo-ssr-slot-state branch October 28, 2024 15:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
diff-available pr: lead review approved Pull request has been approved by a lead review pr: peer review approved Pull request has been approved by a peer review pr: visual review required preview-available target: 1.x
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants