Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

style: rename animation '-time' variables to '-duration' #3187

Merged

Conversation

DavideMininni-Fincons
Copy link
Contributor

@DavideMininni-Fincons DavideMininni-Fincons commented Oct 29, 2024

BREAKING CHANGE: the two variables used for animations have been renamed replacing the word 'time' with 'duration'.

OLD VALUE NEW VALUE
--sbb-disable-animation-zero-time --sbb-disable-animation-zero-duration
--sbb-disable-animation-time --sbb-disable-animation-duration

Copy link
Contributor

@TomMenga TomMenga left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@github-actions github-actions bot added pr: peer review approved Pull request has been approved by a peer review and removed pr: peer review required A peer review is required for this pull request labels Oct 29, 2024
Copy link
Contributor

@jeripeierSBB jeripeierSBB left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@github-actions github-actions bot added the pr: lead review approved Pull request has been approved by a lead review label Oct 29, 2024
@DavideMininni-Fincons DavideMininni-Fincons merged commit e14ee6b into main Oct 30, 2024
36 checks passed
@DavideMininni-Fincons DavideMininni-Fincons deleted the refactor/rename-animation-time-to-duration branch October 30, 2024 08:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
diff-available pr: lead review approved Pull request has been approved by a lead review pr: peer review approved Pull request has been approved by a peer review pr: visual review required preview-available
Projects
None yet
Development

Successfully merging this pull request may close these issues.

rename disable animation "time" variables to "duration"
3 participants