Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

v2.2.0 added comment lines #4

Merged
merged 3 commits into from
Nov 21, 2018
Merged

v2.2.0 added comment lines #4

merged 3 commits into from
Nov 21, 2018

Conversation

germanysources
Copy link
Contributor

Added the comment lines like in the mockup loader version 1.3.0

Copy link
Owner

@sbcgua sbcgua left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

pls have a look on comments

zcl_text2tab_parser.clas.abap Outdated Show resolved Hide resolved
zcl_text2tab_parser.clas.abap Outdated Show resolved Hide resolved
zcl_text2tab_parser.clas.abap Outdated Show resolved Hide resolved
zcl_text2tab_parser.clas.abap Outdated Show resolved Hide resolved
zcl_text2tab_parser.clas.abap Outdated Show resolved Hide resolved
zcl_text2tab_parser.clas.abap Outdated Show resolved Hide resolved
zcl_text2tab_parser.clas.abap Outdated Show resolved Hide resolved
zcl_text2tab_parser.clas.abap Outdated Show resolved Hide resolved
zcl_text2tab_parser.clas.testclasses.abap Outdated Show resolved Hide resolved
zcl_text2tab_parser.clas.xml Show resolved Hide resolved
@germanysources
Copy link
Contributor Author

I added the requested changes.
There is now one unique char at the begin of the line for a comment.

@sbcgua
Copy link
Owner

sbcgua commented Nov 14, 2018

OK, looks fine now, thanks
Just one more request: could you pls mention the feature in the documentation (readme.md). Maybe just add a section somewhere near "date formats"

P.S. btw for stvarv I created a separate issue: #5

@germanysources
Copy link
Contributor Author

The documentation is added in the readme.

@sbcgua
Copy link
Owner

sbcgua commented Nov 21, 2018

Nice! Merging then 🎉

@sbcgua sbcgua merged commit 6cd4e4a into sbcgua:master Nov 21, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants