Fix clang-tidy bug #237
Merged
Fix clang-tidy bug #237
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Tacha-S
force-pushed
the
bugfix/clang-tidy-version
branch
from
e1b06ef to
47e516e
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
clang-tidyをOSのデフォルトで入るバージョンに合わせたことにより、clang-tidyの実行にものすごい時間がかかるようになってしまった、かつ、Error 'omp.h' file not found on clang tidy #236 (comment) にもあるようにシステムヘッダーのエラーを表示してしまうことがあったためシステムヘッダーを無視する方法を模索しましたが、どの方法も(少なくともclang-tidy 18では)うまく行きませんでした。そのため、clangd-tidyというclangdを用いて指定したファイルのみにclang-tidyを実行するwrapperを利用するように変更し、システムヘッダーを無視と高速化の両方を達成しています。 47e516eDetail
Impact
Test
https://github.com/sbgisen/bounding_box_3d_estimation/actions/runs/12764435837/job/35576734928?pr=1
Attention