Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Publish diagnostic #4

Merged
merged 3 commits into from
Jan 16, 2025
Merged

Publish diagnostic #4

merged 3 commits into from
Jan 16, 2025

Conversation

Tacha-S
Copy link

@Tacha-S Tacha-S commented Dec 25, 2024

rgb_raw, depth_raw, ir_raw, imu, pointsに対してdiagnosticを出力するように

@Tacha-S Tacha-S requested a review from a team December 25, 2024 08:07
@Tacha-S Tacha-S marked this pull request as draft December 25, 2024 09:38
@Tacha-S Tacha-S marked this pull request as ready for review December 25, 2024 10:02
@jsupratman13
Copy link

@AiriYokochi @gakutasu @YS-KID @ChiroruNeko

レビューしてみませんか?

Copy link

@gakutasu gakutasu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

変更箇所でない部分で恐縮ですがtypo?があったのでコメントしました。

動作確認できる環境がなく、まだ動確できていませんが、実装は問題ないと思います。
さすがに動確してからマージすべきだと思うので、ほかの方にもレビューお願いしたいです。

src/k4a_ros_device.cpp Outdated Show resolved Hide resolved
@Tacha-S
Copy link
Author

Tacha-S commented Jan 8, 2025

必要であれば自分のデスクの棚にAzure kinect置かれていると思うのでケーブルごと持っていってもらっても大丈夫です。

@Tacha-S
Copy link
Author

Tacha-S commented Jan 14, 2025

@sbgisen/researcher 誰か動作確認できますか?

src/k4a_ros_device.cpp Show resolved Hide resolved
src/k4a_ros_device.cpp Show resolved Hide resolved
@jsupratman13
Copy link

@sbgisen/researcher 誰か動作確認できますか?

動作確認しました。

@jsupratman13
Copy link

@gakutasu
もし問題なければマージしてください

@gakutasu gakutasu merged commit 87a0bdd into jazzy-devel Jan 16, 2025
0 of 2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants