Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support for ROS2 Foxy #76

Open
AJBuilder opened this issue Feb 16, 2023 · 1 comment
Open

Support for ROS2 Foxy #76

AJBuilder opened this issue Feb 16, 2023 · 1 comment
Labels
enhancement New feature or request

Comments

@AJBuilder
Copy link

AJBuilder commented Feb 16, 2023

Abstract

Porting launch files, nodes, and hardware interfaces to ROS2 Foxy.

Purpose

Seems that development skipped over Foxy. There are implementation differences, specifically in the hardware interface, that are not portable from Humble or ROS1.

Implementation Details

As far as I can tell:

  • Hardware interface overrides need changed.
  • Launch files/nodes do not work.

I've started reworking things, starting from #74 , however I am unsure if this is the best branch to start from.

Where would be the ideal commit to start from?

I'd like to include as many developed features as possible, without having to rework more. For instance, Humble ros2_control has Duration arguments for the read() and write() interface functions. I see this is utilized in newer features, but would have to be reworked considering Foxy read() and write() have no arguments.

@AJBuilder AJBuilder added the enhancement New feature or request label Feb 16, 2023
@Tacha-S
Copy link
Contributor

Tacha-S commented Feb 17, 2023

Thanks for your working.
#74 has not migrated all the functions of ROS1 hardware interface.
But if all you are concerned about is the difference in read(), write() specifications and the fact that you want a sample launch/node, I would appreciate it if you could backport #74 and reworking for Foxy.

As for Duration, the same behavior could be implemented by keeping the previous time for each read() and write() operation.
If timer events or threads can be run internally as in ROS1, that would be great too.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants