Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #1285 an #1284
1D pytorch distributions such as
torch.distributions.Exponential
,.Uniform
, or.Normal
do not, by default return any sample or batch dimension. E.g.:sbi
will raise an error that the sample dimension is missing. A simple solution is to add a batch dimension todist
as follows:Unfortunately, this
dist
will return the batch dimension also for `.log_prob():This will lead to unexpected errors in
sbi
. The point of this PR is to wrap those batched 1D distributions to get rid of their batch dimension in.log_prob()
.