Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clarify tutorial on multi-round #917

Merged
merged 1 commit into from
Jan 24, 2024
Merged

Clarify tutorial on multi-round #917

merged 1 commit into from
Jan 24, 2024

Conversation

michaeldeistler
Copy link
Contributor

The inference object did not get instantiated in the multi round tutorial.

Closes #916

Copy link

codecov bot commented Jan 23, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (696d5f7) 75.46% compared to head (0213fc9) 75.46%.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #917   +/-   ##
=======================================
  Coverage   75.46%   75.46%           
=======================================
  Files          80       80           
  Lines        6284     6284           
=======================================
  Hits         4742     4742           
  Misses       1542     1542           
Flag Coverage Δ
unittests 75.46% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@janfb janfb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@michaeldeistler michaeldeistler merged commit 9e224da into main Jan 24, 2024
3 checks passed
@michaeldeistler michaeldeistler deleted the fixuptut branch January 24, 2024 11:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

inference not defined in multi-round proposal
2 participants