Skip to content
This repository has been archived by the owner on Apr 10, 2023. It is now read-only.

full rewrite of munin_plugin.py to be Ansible 2.0 compatible #17

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

drzraf
Copy link
Contributor

@drzraf drzraf commented May 11, 2016

This is a rewrite of the action-plugin.

  • Use latest internal plugin API
  • more concise
  • keeps backward compatibility
  • no "extra" file dependency anymore (that template.conf.j2 thing)
  • no dependency upon the template module anymore

It's slower than v1* version (as is Ansible generally)

@drzraf
Copy link
Contributor Author

drzraf commented Jul 2, 2016

ping

1 similar comment
@drzraf
Copy link
Contributor Author

drzraf commented Aug 19, 2016

ping

@jonhattan
Copy link
Member

It doesn't seem to me that the approach in this PR is equivalent to the current behaviour. You removed the service notification?

@jonhattan
Copy link
Member

As stated in #14, we won't continue supporting this role.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants