Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Move encryption and api functions into the base class #277

Merged
merged 4 commits into from
Dec 20, 2024
Merged

Move encryption and api functions into the base class #277

merged 4 commits into from
Dec 20, 2024

Conversation

bdraco
Copy link
Member

@bdraco bdraco commented Dec 20, 2024 •
edited
Loading

Tested with a lock

@codecov Codecov
Copy link

codecov bot commented Dec 20, 2024 •
edited
Loading

Codecov Report

Attention: Patch coverage is 41.02564% with 46 lines in your changes missing coverage. Please review.

Files with missing lines Patch % Lines
switchbot/devices/device.py 34.84% 43 Missing ⚠️
switchbot/devices/lock.py 66.66% 2 Missing ⚠️
switchbot/devices/relay_switch.py 83.33% 1 Missing ⚠️
Files with missing lines Coverage Δ
switchbot/devices/relay_switch.py 52.25% <83.33%> (-1.47%) ⬇️
switchbot/devices/lock.py 34.93% <66.66%> (+5.80%) ⬆️
switchbot/devices/device.py 42.59% <34.84%> (-1.55%) ⬇️

@bdraco bdraco marked this pull request as ready for review December 20, 2024 19:34
@bdraco bdraco merged commit 9f939ce into master Dec 20, 2024
7 of 8 checks passed
@bdraco bdraco deleted the de_dupe branch December 20, 2024 19:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@bdraco