Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Extract common methods for encrypted devices into the base class #297

Merged
merged 4 commits into from
Feb 4, 2025
Merged

Extract common methods for encrypted devices into the base class #297

merged 4 commits into from
Feb 4, 2025
+56 −112

Conversation

dsypniewski
Copy link
Contributor

No description provided.

@codecov Codecov
Copy link

codecov bot commented Feb 3, 2025 •
edited
Loading

Codecov Report

Attention: Patch coverage is 21.05263% with 30 lines in your changes missing coverage. Please review.

Files with missing lines Patch % Lines
switchbot/devices/device.py 21.05% 30 Missing ⚠️
Files with missing lines Coverage Δ
switchbot/devices/lock.py 40.18% <ø> (+5.25%) ⬆️
switchbot/devices/relay_switch.py 70.00% <ø> (+15.29%) ⬆️
switchbot/devices/device.py 40.85% <21.05%> (-1.75%) ⬇️

@bdraco bdraco merged commit e1ac5a3 into sblibs:master Feb 4, 2025
4 of 5 checks passed
@dsypniewski dsypniewski deleted the encrypted_devices_cleanup branch February 6, 2025 16:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bdraco bdraco bdraco approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@dsypniewski @bdraco