Use rustls-pki-types via rustls crate #155
Conversation
Cargo.toml
Outdated
| @@ -25,7 +25,7 @@ multipart = {version = "0.18.0", default-features = false, features = ["client"] | |||
| native-tls = {version = "0.2.10", optional = true} | |||
| rustls-native-certs = { version = "0.7", optional = true} | |||
| rustls-opt-dep = {package = "rustls", version = "0.22.0", optional = true} | |||
| rustls-pki-types = "1" | |||
| rustls-pki-types = {version = "1", optional = true} | |||
There was a problem hiding this comment.
I don't this dependency is necessary at all as the types are re-exported as rustls::pki_types.
There was a problem hiding this comment.
The re-exporting was introduced at rustls 0.22.1. So when we want to use rustls-pki-types crate via rustls, we have to set the rustls minimum version requirement as 0.22.1 instead of 0.22.0. Which option is appropriate for attohttpc?
There was a problem hiding this comment.
Since 0.22.1 is fully semver-compatible with 0.22.0, I see little downside to bumping rustls. Most leaf projects will regularly run cargo update anyway so that the final result would be the same.
There was a problem hiding this comment.
Sure. I will change to use rustls-pki-types via rustls crate.
tottoto
changed the title
|
Awesome thanks to you both |
rustls-pki-typesis only used in__rustlsfeature.