GHA updates #540
Merged
GHA updates #540
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* update actions/setup-java 3 -> 4 * make `jobtype` more descriptive
eed3si9n
requested changes
Oct 20, 2024
.github/workflows/ci.yml
Outdated
| with: | ||
| distribution: "${{ matrix.distribution }}" | ||
| java-version: "${{ matrix.java }}" | ||
| cache: sbt | ||
| - uses: sbt/setup-sbt@v1 | ||
| - name: Build and test (sbt 1.x) | ||
| if: ${{ matrix.jobtype == 1 }} | ||
| if: ${{ matrix.jobtype == sbt-1 }} |
There was a problem hiding this comment.
This failed - https://github.com/sbt/sbt-assembly/actions/runs/11425010983
The workflow is not valid. .github/workflows/ci.yml (Line: 49, Col: 11): Unrecognized named-value: 'sbt-1'. Located at position 19 within expression: matrix.jobtype == sbt-1 .github/workflows/ci.yml (Line: 54, Col: 11): Unrecognized named-value: 'sbt-2'. Located at position 19 within expression: matrix.jobtype == sbt-2
eed3si9n
approved these changes
Oct 20, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
jobtypemore descriptive