Add setting for path in preview #147
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
2m
reviewed
May 21, 2019
2m
reviewed
May 21, 2019
2m
reviewed
May 21, 2019
| @@ -13,6 +13,7 @@ object SitePreviewPlugin extends AutoPlugin { | |||
| val previewAuto = TaskKey[Unit]("previewAuto", "Launches an automatic jetty server that serves your generated site from the target directory") | |||
| val previewFixedPort = SettingKey[Option[Int]]("previewFixedPort") in previewSite | |||
| val previewLaunchBrowser = SettingKey[Boolean]("previewLaunchBrowser") in previewSite | |||
| val previewPath = SettingKey[String]("previewPath", "path to open on `previewSite` and `previewAuto`") in previewSite | |||
There was a problem hiding this comment.
Its a bit strange that these settings are defined as in previewSite but then are used in both previewSite and previewAuto. But that is for later.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This implements #142 by adding
previewPathwhich gets added to the URL opened bypreviewSiteandpreviewAuto.