Make zinc-scripted show up in IntelliJ
#1298
Conversation
|
Since this PR is changing some logics written by you, would you mind to take a look at this PR? (and preferably also take a look at #1297, since both PR are closely related). I will be busy for the rest of December since I have a couple exams to deal with, so I might not be able to immediately respond to PR feedbacks, but I will still try my best to address feedbacks ASAP. |
| @@ -667,9 +666,6 @@ lazy val zincScripted = (projectMatrix in internalPath / "zinc-scripted") | |||
| ) | |||
| .defaultAxes(VirtualAxis.jvm, VirtualAxis.scalaPartialVersion(scala212)) | |||
| .jvmPlatform(scalaVersions = List(scala212)) | |||
| .configure( | |||
| _.dependsOn(compilerBridge210, compilerBridge211, compilerBridge212, compilerBridge213) | |||
There was a problem hiding this comment.
This makes zincScripted depend on all compiler bridge JARs whereas the one above will only depend on the ones for Scala 2.12? I wonder if this was meant to create build order dependency so calling the scripted test would force rebuilding compiler bridges when we change the bridge imple. Could you check if that still works plz?
|
I no longer remember what I might have been thinking. I'm not even confident what commits you might be referring to — sbt/zinc@4d39439 ? regardless, probably I was just fumbling around if you ask a more specific question it might ring a bell in my memory, but otherwise we should probably just rely on Eugene's say-so; I see he already merged the other PR |
|
Closing this for now for inactivity. Feel free to reopen this if you want to pick this up. |
Fixes other half of #1296
Validate the fix:
(As shown in screenshot, smart IDE features are now working)