[1.x] Handle parsing of non-problems in JavaErrorParser
#1455
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue
JavaErrorParser
assumesjavac
outputs start with a list of problems or notes. However in certain situationsjavac
emits the following lines firstwhich is neither problems nor notes. The parser then gives up and parse nothing. Hence
JavaCompilerSpec
fails.Fix
We explicitly match for lines that start with "Loading source file" or "Constructing Javadoc information" and skip these lines before parsing problems / notes.
Validating the fix
I tested on a Java 17 windows machine that emits the below during
JavaCompilerSpec
The test passed locally.
Closes #1451