Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[1.x] Clean compile warnings #1472

Merged
merged 5 commits into from
Oct 19, 2024

Conversation

Friendseeker
Copy link
Member

@Friendseeker Friendseeker commented Oct 18, 2024

Backport #1458

Also fixes a bunch more Scala 2.13 deprecation warnings caused by deprecated implicit conversion from Array to Seq. (and with a couple other different deprecation warnings).

method copyArrayToImmutableIndexedSeq in class LowPriorityImplicits2 is deprecated (since 2.13.0): implicit conversions from Array to immutable.IndexedSeq are implemented by copying; use `toIndexedSeq` explicitly if you want to copy, or use the more efficient non-copying ArraySeq.unsafeWrapArray

Somehow Scala 3 CI build did not complain about them but Scala 2.13 CI build did.

@Friendseeker Friendseeker force-pushed the clear-compiler-warning-1 branch from 60f90e4 to ded7248 Compare October 18, 2024 19:29
@Friendseeker Friendseeker force-pushed the clear-compiler-warning-1 branch from 3c7fd55 to 3dc6783 Compare October 18, 2024 21:27
@Friendseeker Friendseeker marked this pull request as ready for review October 18, 2024 23:59
@Friendseeker Friendseeker force-pushed the clear-compiler-warning-1 branch from 2a4d78d to e74d3e4 Compare October 19, 2024 02:00
Copy link
Member

@eed3si9n eed3si9n left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@eed3si9n eed3si9n merged commit 24012b9 into sbt:1.10.x Oct 19, 2024
9 checks passed
@Friendseeker Friendseeker deleted the clear-compiler-warning-1 branch October 19, 2024 05:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants