[1.x] Let Scala Steward auto-update com.google.protobuf
#1501
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Friendseeker
changed the title
com.google.protobuf versioncom.google.protobuf
eed3si9n
reviewed
Nov 24, 2024
Friendseeker
force-pushed
the
protobuf-opt-in
branch
from
9a9a22f to
eb96c19
Compare
eed3si9n
approved these changes
Nov 25, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Due to popularity of
com.google.protobuf, CVE reports oncom.google.protobufare quite common. Sooner or later Zinc's current version ofcom.google.protobufwill be flagged again.This needs further discussion but I wonder if we should auto update
com.google.protobuf.Previously we decided to opt-out of auto update
com.google.protobufdue to worry about regression, but as we have experienced, sticking with the samecom.google.protobufversion can also inevitably cause Zinc to be flagged by security software for depending on a vulnerable dependency.We also have really strong unit tests for serialization / deserialization that minimizes the risk of regression. For instance our CI caught several issues related to Consistent Analysis Format, including an intermittent deadlock issue.