Use project-specific compiler settings when evaluating a worksheet. #175
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Test PASSed. |
No test since there is no easy way to trigger some observable effect from compiler settings, other than using compiler plugins (and continuations are missing from the 2.11 build). * -deprecation or -feature won't work because warnings are not reported (see scala-ide#174) * the continuations plugin isn't part of 2.11, so tests would only work in 2.10 However, I think the integration test isn't really necessary: `scalacArguments` is part of `sdt.core` and used by the sbt builder. Fixed scala-ide#173
|
Test PASSed. |
|
Did you smoke tested that compiler plug-ins are picked up? If yes, then LGTM. |
|
Yes, I forgot to mention that. I manually tested it using the continuations plugin on 2.10, and it worked. However, new settings take effect only after a successful build (same as for classpath changes, before this PR). |
|
LGTM, of course ! |
|
👍 |
dragos
added a commit
that referenced
this pull request
Feb 11, 2014
Use project-specific compiler settings when evaluating a worksheet.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No test since there is no easy way to trigger some observable effect from
compiler settings, other than using compiler plugins (and continuations are
missing from the 2.11 build).
However, I think the integration test isn't really necessary:
scalacArgumentsis part of
sdt.coreand used by the sbt builder.Fixed #173