Remove experimental MainAnnotation/newMain (replaced with MacroAnnotation)
#19937
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
nicolasstucki
force-pushed
the
remove-experimental-MainAnnotation
branch
from
d225068 to
7fd9f68
Compare
nicolasstucki
added
the
needs-minor-release
|
though doing it sooner would technically be fair game, removing from next minor seems fine since there's no particular gain for us to do it sooner, this code doesn't get in our way |
…nnotation`) `MainAnnotation` and its implementation `newMain` predate `MacroAnnotation`. The `MacroAnnotation` is subsumed feature and allows much more flexibility. `MainAnnotation` and `newMain` could be reimplemented as a macro annotation in an external library. See SIP-63: scala/improvement-proposals#80
nicolasstucki
force-pushed
the
remove-experimental-MainAnnotation
branch
from
7fd9f68 to
ad871ee
Compare
odersky
approved these changes
Mar 28, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
MainAnnotationand its implementationnewMainpredateMacroAnnotation. TheMacroAnnotationis subsumed feature and allows much more flexibility.MainAnnotationandnewMaincould be reimplemented as a macro annotation in an external library.See SIP-63: scala/improvement-proposals#80
When should this be removed?
As an experimental feature, we can remove it in any patch release. We have 2 options:
Complete: We remove it as soon as we can, next patch release of 3.4 or 3.5. We also remove it from the next 3.3 LTS patch release.