-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Do not crash when typing a closure with unknown type, since it can occur for erroneous input #21178
Merged
Merged
Changes from all commits
Commits
Show all changes
3 commits
Select commit
Hold shift + click to select a range
ec5cbcc
Do not crash when typing a closure with unknown type, since it can oc…
KacperFKorban 74920d3
Don't typeAhead erroneous parsing trees related to export statements
KacperFKorban 6e28679
Don't explicitly check for error trees in export selectors
KacperFKorban File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,32 @@ | ||
-- [E083] Type Error: tests/neg/i20511-1.scala:7:7 --------------------------------------------------------------------- | ||
7 |export toppingPrice.apply, crustPrice.apply, crustPrice.unlift // error // error // error // error // error | ||
| ^^^^^^^^^^^^ | ||
| Int => Double is not a valid export prefix, since it is not an immutable path | ||
| | ||
| longer explanation available when compiling with `-explain` | ||
-- [E083] Type Error: tests/neg/i20511-1.scala:7:27 -------------------------------------------------------------------- | ||
7 |export toppingPrice.apply, crustPrice.apply, crustPrice.unlift // error // error // error // error // error | ||
| ^^^^^^^^^^ | ||
| Any is not a valid export prefix, since it is not an immutable path | ||
| | ||
| longer explanation available when compiling with `-explain` | ||
-- Error: tests/neg/i20511-1.scala:7:38 -------------------------------------------------------------------------------- | ||
7 |export toppingPrice.apply, crustPrice.apply, crustPrice.unlift // error // error // error // error // error | ||
| ^^^^^ | ||
| no eligible member apply at { | ||
| def $anonfun(crustType: Double): Double = pakiet.crustPrice(crustType) | ||
| closure(pakiet.$anonfun:Any) | ||
| } | ||
-- [E083] Type Error: tests/neg/i20511-1.scala:7:45 -------------------------------------------------------------------- | ||
7 |export toppingPrice.apply, crustPrice.apply, crustPrice.unlift // error // error // error // error // error | ||
| ^^^^^^^^^^ | ||
| Any is not a valid export prefix, since it is not an immutable path | ||
| | ||
| longer explanation available when compiling with `-explain` | ||
-- Error: tests/neg/i20511-1.scala:7:56 -------------------------------------------------------------------------------- | ||
7 |export toppingPrice.apply, crustPrice.apply, crustPrice.unlift // error // error // error // error // error | ||
| ^^^^^^ | ||
| no eligible member unlift at { | ||
| def $anonfun(crustType: Double): Double = pakiet.crustPrice(crustType) | ||
| closure(pakiet.$anonfun:Any) | ||
| } |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,7 @@ | ||
package pakiet | ||
|
||
def toppingPrice(size: Int): Double = ??? | ||
|
||
def crustPrice(crustType: Double): Double = ??? | ||
|
||
export toppingPrice.apply, crustPrice.apply, crustPrice.unlift // error // error // error // error // error |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,14 @@ | ||
-- [E040] Syntax Error: tests/neg/i20511.scala:7:19 -------------------------------------------------------------------- | ||
7 |export toppingPrice, crustPrice // error // error | ||
| ^ | ||
| '.' expected, but ',' found | ||
-- [E040] Syntax Error: tests/neg/i20511.scala:8:0 --------------------------------------------------------------------- | ||
8 |val i = 1 // error | ||
|^^^ | ||
|'.' expected, but 'end of statement' found | ||
-- [E083] Type Error: tests/neg/i20511.scala:7:21 ---------------------------------------------------------------------- | ||
7 |export toppingPrice, crustPrice // error // error | ||
| ^^^^^^^^^^ | ||
| Any is not a valid export prefix, since it is not an immutable path | ||
| | ||
| longer explanation available when compiling with `-explain` |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,8 @@ | ||
package pakiet | ||
|
||
def toppingPrice(size: Int): Double = ??? | ||
|
||
def crustPrice(crustType: Double): Double = ??? | ||
|
||
export toppingPrice, crustPrice // error // error | ||
val i = 1 // error |
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't think this is the correct fix. IMHO, for this kind of errors, we shouldn't run the typer in the first place.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hmmm, I think that this might actually be the correct fix. I even tried short-circuiting before typing ahead in Namer, but the presentation compiler leverages this for completions.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Alright, but we should open an issue for a better error messages !