Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Backport "Remove stdlib213 from community build tests" to LTS #21996

Merged
merged 1 commit into from
Dec 2, 2024

Conversation

prolativ
Copy link
Contributor

Backports #18801 to the LTS branch.

PR submitted by the release tooling.
[skip ci]

This test exists for historical reasons. Now we compile the Scala 2
library in the `scala2-library-bootstrapped` project. This one checks
that it compiles (with `-Ycheck:all`) and is used to package the TASTy
files in the `scala2-library-tasty` project. Furthermore, now there is
a `scala/scala` test that checks that the library can be compiled with
Scala 3.

This test is fundamentally broken but we have not noticed it because we
do not use `-Ycheck:all`. The reason is that when we compile `scala.Predef`
we get a conflict with `scala.runtime.stdLibPatches.Predef` when we patch
the symbols. This also surfaced in #18738.

[Cherry-picked 8c6f4c7]
Base automatically changed from backport-lts-3.3-21120 to lts-3.3 December 2, 2024 17:38
@WojciechMazur
Copy link
Contributor

No regressions detected in the community build up to backport-lts-3.3-21186.

Reference

@WojciechMazur WojciechMazur merged commit 64d7afc into lts-3.3 Dec 2, 2024
19 checks passed
@WojciechMazur WojciechMazur deleted the backport-lts-3.3-18801 branch December 2, 2024 17:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants