Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update Scala CLI to 1.5.4 (was 1.5.1) & coursier to 2.1.18 (was 2.1.13) #22021

Merged
merged 2 commits into from
Nov 25, 2024
Merged

Update Scala CLI to 1.5.4 (was 1.5.1) & coursier to 2.1.18 (was 2.1.13) #22021

merged 2 commits into from
Nov 25, 2024

Conversation

Gedochao
Copy link
Contributor

@Gedochao Gedochao added the needs-minor-release This PR cannot be merged until the next minor release label Nov 25, 2024
@Gedochao Gedochao added this to the 3.6.2 milestone Nov 25, 2024
@Gedochao Gedochao added the release-notes Should be mentioned in the release notes label Nov 25, 2024
@Gedochao Gedochao changed the title Update Scala CLI to 1.5.4 & coursier to 2.1.18 Update Scala CLI to 1.5.4 (was 1.5.1) & coursier to 2.1.18 (was 2.1.13) Nov 25, 2024
@Gedochao
Copy link
Contributor Author

(The GH action was bumped in #22020)

hamzaremmal
hamzaremmal approved these changes Nov 25, 2024
View reviewed changes
Copy link
Member

@hamzaremmal hamzaremmal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is way too early to do this, but as of today, this changes are valid

@WojciechMazur WojciechMazur added the backport:nominated If we agree to backport this PR, replace this tag with "backport:accepted", otherwise delete it. label Nov 25, 2024
@WojciechMazur WojciechMazur merged commit 0afabd6 into scala:main Nov 25, 2024
29 checks passed
WojciechMazur pushed a commit that referenced this pull request Nov 25, 2024
@Gedochao @WojciechMazur
Update Scala CLI to 1.5.4 (was 1.5.1) & coursier to 2.1.18 (was 2.1…
73d9179 
….13) (#22021)

https://github.com/VirtusLab/scala-cli/releases/tag/v1.5.4
https://github.com/coursier/coursier/releases/tag/v2.1.18
cc @WojciechMazur
[Cherry-picked 0afabd6]
@WojciechMazur WojciechMazur mentioned this pull request Nov 25, 2024
Open
@WojciechMazur WojciechMazur added backport:accepted This PR needs to be backported, once it's been backported replace this tag by "backport:done" and removed backport:nominated If we agree to backport this PR, replace this tag with "backport:accepted", otherwise delete it. labels Nov 25, 2024
@Gedochao Gedochao deleted the update/scala-cli-1.5.4-coursier-2.1.18 branch November 26, 2024 07:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hamzaremmal hamzaremmal hamzaremmal approved these changes

@WojciechMazur WojciechMazur WojciechMazur approved these changes

Assignees

@hamzaremmal hamzaremmal

Labels
backport:accepted This PR needs to be backported, once it's been backported replace this tag by "backport:done" needs-minor-release This PR cannot be merged until the next minor release release-notes Should be mentioned in the release notes
Projects
None yet
Milestone
3.6.2
Development

Successfully merging this pull request may close these issues.
3 participants
@Gedochao @WojciechMazur @hamzaremmal