Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

re-add code tracking macroExpand times #133

Merged
merged 3 commits into from
Jul 28, 2024
Merged

Conversation

DSlug
Copy link
Contributor

@DSlug DSlug commented Jul 12, 2024

No description provided.

@github-actions github-actions bot added the scalac-profiling Relates to the compiler plugin label Jul 12, 2024
Copy link
Collaborator

@danicheg danicheg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I managed to validate this PR on the Scala-Steward repo. Several notes:

  • expansionNanos became more plausible;
  • expandedNodes are still blank for all entries.

From the perspective of practical benefits, it's better to have some intuitions about the time taken during macro expansions. I'm only concerned about examining why the original author pulled out of the library that approach for measuring. That was done intentionally, in one hop. But I also don't think I will manage to motivate myself to spend more time investigating this. Given that, I'll wait for a while until some miracle happens and someone either unconfuses this or I will merge PR one day and ship it as is.

@danicheg danicheg merged commit 67d5cb0 into scalacenter:main Jul 28, 2024
21 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
scalac-profiling Relates to the compiler plugin
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants