Skip to content

Commit

Permalink
Disable EOL Conversion On /.jvmopts
Browse files Browse the repository at this point in the history
Add a `.gitattributes` file to prevent end of line (EOL) conversion on the `/.jvmopts` file. This was the causing windows based CI failures as the JVM options were being parsed with a carriage return at the end of them.

This commit also re-enables use of the `.jvmopts` file in the Windows CI environment.
  • Loading branch information
isomarcte committed Dec 8, 2019
1 parent 9533e87 commit 1ecb632
Show file tree
Hide file tree
Showing 2 changed files with 1 addition and 3 deletions.
1 change: 1 addition & 0 deletions .gitattributes
Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
/.jvmopts eol=lf
3 changes: 0 additions & 3 deletions .github/workflows/ci.yml
Original file line number Diff line number Diff line change
Expand Up @@ -12,14 +12,11 @@ jobs:
fail-fast: false
matrix:
os: [ubuntu-latest, windows-latest, macOS-latest]
env:
JAVA_OPTS: -Xss4m -Xms1G -Xmx8G -XX:ReservedCodeCacheSize=1024m -XX:+TieredCompilation -XX:+CMSClassUnloadingEnabled -Dfile.encoding=UTF-8 -Djna.nosys=true
steps:
- uses: actions/checkout@v1
- uses: olafurpg/setup-scala@v7
- name: Run unit tests
run: |
rm .jvmopts
bin/test.sh unit/test
shell: bash
sbt:
Expand Down

0 comments on commit 1ecb632

Please sign in to comment.