fix for #850: transpose-slice-multiply crash #862
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The fix consisted of changing the comparison operator from
<
to>
here:diff math/src/main/codegen/breeze/linalg/operators/DenseMatrixOps.scala
The problem occurs when
majorStride
is too big rather than too small, so acopy
is needed.This might represent a performance improvement, on average, if it results in fewer calls to
_.copy
.added a test to math/src/test/scala/breeze/linalg/DenseMatrixTest.scala
Also fixed a test that was failing in
Windows
due to a hardwired/
path separator:math/src/test/scala/breeze/linalg/TextOperationsTest.scala
Fixed it by converting
\\
to '/' to find the correct relative path to the resource file.Upgraded thesbt
version becausesbt
was crashing.Upgraded scala versions.
One test was failing on my system before I made any modifications, and is still failing now, so not sure what that's about.