fix(modal): handle events and focus #2889
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: e19dd06 The changes in this PR will be included in the next version bump. This PR includes changesets to release 4 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
DorianMaliszewski
force-pushed
the
feat/modal-events
branch
from
de85f94
to
beb6ebd
Compare
size-limit report 📦
|
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## main #2889 +/- ##
==========================================
- Coverage 94.16% 93.47% -0.69%
==========================================
Files 154 154
Lines 3170 3204 +34
Branches 409 416 +7
==========================================
+ Hits 2985 2995 +10
- Misses 117 141 +24
Partials 68 68
... and 1 file with indirect coverage changes Continue to review full report in Codecov by Sentry.
|
DorianMaliszewski
force-pushed
the
feat/modal-events
branch
from
beb6ebd
to
6067c87
Compare
QuiiBz
reviewed
Sep 7, 2023
matthprost
approved these changes
Sep 7, 2023
vincentaudebert
approved these changes
Sep 7, 2023
QuiiBz
approved these changes
Sep 7, 2023
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Type
Summarise concisely:
What is expected?
Handle events when modal is open to trap focus and prevent elements outisde of the modal being impacted
The following changes where made:
(Describe what you did)
Relevant logs and/or screenshots