Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(CheckboxField): no working properly with children #4384

Merged
merged 1 commit into from
Oct 24, 2024
Merged

Conversation

matthprost
Copy link
Collaborator

Summary

Type

  • Bug

Summarise concisely:

What is expected?

Bug on CheckboxField not adding children

@matthprost matthprost added the bug Something isn't working label Oct 23, 2024
@matthprost matthprost self-assigned this Oct 23, 2024
Copy link

changeset-bot bot commented Oct 23, 2024

🦋 Changeset detected

Latest commit: f682f93

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@ultraviolet/form Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link

codecov bot commented Oct 23, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 92.15%. Comparing base (842279d) to head (f682f93).
Report is 9 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #4384      +/-   ##
==========================================
+ Coverage   86.76%   92.15%   +5.38%     
==========================================
  Files         318       63     -255     
  Lines       11640     1338   -10302     
  Branches     3231      197    -3034     
==========================================
- Hits        10100     1233    -8867     
+ Misses       1540      105    -1435     
Files with missing lines Coverage Δ
...ckages/form/src/components/CheckboxField/index.tsx 100.00% <100.00%> (+6.66%) ⬆️

... and 255 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 842279d...f682f93. Read the comment docs.

@matthprost matthprost merged commit 6b53102 into main Oct 24, 2024
12 checks passed
@matthprost matthprost deleted the fix/checkbox branch October 24, 2024 09:24
@scaleway-bot scaleway-bot mentioned this pull request Oct 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants