Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(ProgressBar): prefix, suffix and max #4509

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

lisalupi
Copy link
Contributor

Summary

Type

  • Enhancement

Summarise concisely:

What is expected?

<ProgressBar />: new props max, prefix and suffix

@lisalupi lisalupi requested a review from a team November 27, 2024 13:06
@lisalupi lisalupi self-assigned this Nov 27, 2024
@lisalupi lisalupi requested review from BABAK0T0 and removed request for a team November 27, 2024 13:06
Copy link

changeset-bot bot commented Nov 27, 2024

🦋 Changeset detected

Latest commit: 57da1cf

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 3 packages
Name Type
@ultraviolet/ui Minor
@ultraviolet/form Patch
@ultraviolet/plus Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link

codecov bot commented Nov 27, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 87.44%. Comparing base (6740685) to head (57da1cf).

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #4509      +/-   ##
==========================================
+ Coverage   87.40%   87.44%   +0.03%     
==========================================
  Files         334      334              
  Lines       12601    12617      +16     
  Branches     3488     3448      -40     
==========================================
+ Hits        11014    11033      +19     
+ Misses       1587     1584       -3     
Files with missing lines Coverage Δ
...rc/components/ProgressBar/__tests__/index.test.tsx 100.00% <100.00%> (ø)
packages/ui/src/components/ProgressBar/index.tsx 100.00% <100.00%> (+6.25%) ⬆️

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6740685...57da1cf. Read the comment docs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants