tentative fix for the maxKeys==0 bug + unit test

Issue #250
scality · May 2, 2017 · 1db5909 · 1db5909
1 parent 06281f7
commit 1db5909
Show file tree

Hide file tree

Showing 2 changed files with 13 additions and 3 deletions.
diff --git a/lib/algos/list/delimiter.js b/lib/algos/list/delimiter.js
@@ -55,7 +55,8 @@ class Delimiter extends Extension {
         this.delimiter = parameters.delimiter;
         this.prefix = parameters.prefix;
         this.marker = parameters.marker;
-        this.maxKeys = parameters.maxKeys || 1000;
+        this.maxKeys = (parameters.maxKeys !== undefined ?
+                        parameters.maxKeys : 1000);
         // results
         this.CommonPrefixes = [];
         this.Contents = [];
@@ -99,8 +100,8 @@ class Delimiter extends Extension {
      */
     _reachedMaxKeys() {
         if (this.keys >= this.maxKeys) {
-            // In cases of maxKeys <= 0 -> IsTruncated = false
-            this.IsTruncated = this.maxKeys > 0;
+            // In cases of maxKeys < 0 -> IsTruncated = false
+            this.IsTruncated = this.maxKeys >= 0;
             return true;
         }
         return false;

diff --git a/tests/unit/algos/list/delimiter.js b/tests/unit/algos/list/delimiter.js
@@ -123,6 +123,15 @@ const tests = [
         IsTruncated: false,
         NextMarker: undefined,
     }),
+    new Test('with zero makKeys', {
+        maxKeys: 0,
+    }, {
+        Contents: [],
+        CommonPrefixes: [],
+        Delimiter: undefined,
+        IsTruncated: true,
+        NextMarker: undefined,
+    }),
     new Test('with delimiter', {
         delimiter: '/',
     }, {