Skip to content

Commit

Permalink
ARSN-367:principal change on schema and test add
Browse files Browse the repository at this point in the history
The maximum length should be 2048 characters
having 31 characters on the fixed length prefix
this explains the 2017 max limit put in the schema

(cherry picked from commit 73c6f41)
  • Loading branch information
benzekrimaha committed Oct 6, 2023
1 parent 1da218d commit 7e5e4fd
Show file tree
Hide file tree
Showing 3 changed files with 7 additions and 2 deletions.
2 changes: 1 addition & 1 deletion lib/policy/resourcePolicySchema.json
Original file line number Diff line number Diff line change
Expand Up @@ -38,7 +38,7 @@
},
"principalAWSUserArn": {
"type": "string",
"pattern": "^arn:aws:iam::[0-9]{12}:user/(?!\\*)[\\w+=,.@ -/]{1,64}$"
"pattern": "^arn:aws:iam::[0-9]{12}:user/(?!\\*)[\\w+=,.@ -/]{1,2017}$"
},
"principalAWSRoleArn": {
"type": "string",
Expand Down
2 changes: 1 addition & 1 deletion lib/policy/userPolicySchema.json
Original file line number Diff line number Diff line change
Expand Up @@ -28,7 +28,7 @@
},
"principalAWSUserArn": {
"type": "string",
"pattern": "^arn:aws:iam::[0-9]{12}:user/(?!\\*)[\\w+=,.@ -/]{1,64}$"
"pattern": "^arn:aws:iam::[0-9]{12}:user/(?!\\*)[\\w+=,.@ -/]{1,2017}$"
},
"principalAWSRoleArn": {
"type": "string",
Expand Down
5 changes: 5 additions & 0 deletions tests/unit/policy/test_policyValidator.spec.js
Original file line number Diff line number Diff line change
Expand Up @@ -188,6 +188,11 @@ describe('Policies validation - Principal', () => {
value: { AWS: 'arn:aws:iam::111111111111:user/path/in/org/leaf' },
policyType: [user, resource],
},
{
name: 'user arn with vault made path',
value: { AWS: 'arn:aws:iam::767707094035:user/user2/TENANT_USER/null/5417be27-8709-48bd-adfb-865ebc58b9f0/1a464be02ea631bdaf2a9ee884434233374a457460e925bf10d9e4665f8fa796/c1d83067-a3f3-41a4-bd45-d6bf47270bd0' }, // eslint-disable-line max-len
policyType: [user, resource],
},
{
name: 'multiple user arns',
value: {
Expand Down

0 comments on commit 7e5e4fd

Please sign in to comment.