[Tests](fix): Fix flaky test timeout #111
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
👍 |
|
Can you fix the commit message typo, from |
|
I just realized, this should probably go into rel/1.1 since it's not related to just Smart Bulb release |
- Increase timeout to remove flaky test from public Circle CI
alexandre-merle
force-pushed
the
fix/flacky-test
branch
from
93bfa48 to
5db3a37
Compare
|
Done :) |
alexandre-merle
changed the title
|
you right :) i will do that too |
|
👍 :) Failed too many times for nothing :D |
|
Note: This one should be closed in favor of #113 |
|
@DavidPineauScality this one is for master :) |
|
Yes, and that's what forward ports are for. To port fixes pushed into release branches into the associated master branches. |
|
Closing for #114 :) |
ghost
deleted the
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
public Circle CI
Fixes #93