Pull all required headers to be signed. #134
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Related to S3 open issue scality/cloudserver#120 :) |
| Object.assign(request.headers, request._headers); | ||
| const signedHeaders = Object.keys(request._headers) | ||
| .filter(headerName => | ||
| headerName.startsWith('x-amz-') || headerName.startsWith('x-scal') |
There was a problem hiding this comment.
x-amz is enought since it's x-amz-scal for custom headers :)
There was a problem hiding this comment.
I include both in the required headers test in case x-scal headers are created later.
|
two minor comments :) 👍 |
LaurenSpiegel
force-pushed
the
ft/dynamicSignedHeaders
branch
from
f460fbc to
201f54d
Compare
LaurenSpiegel
force-pushed
the
ft/dynamicSignedHeaders
branch
from
201f54d to
18d657b
Compare
|
@DavidPineauScality and @AntoninCoulibaly, note this has a small impact on #119 |
LaurenSpiegel
force-pushed
the
ft/dynamicSignedHeaders
branch
from
5035dd4 to
18d657b
Compare
|
end to end passed http://ci.ironmann.io/gh/scality/Integration/2545 |
|
LGTM 👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes scality/cloudserver#120