-
Notifications
You must be signed in to change notification settings - Fork 20
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bugfix/arsn 371 useunifiedtopology #2179
Bugfix/arsn 371 useunifiedtopology #2179
Conversation
Hello williamlardier,My role is to assist you with the merge of this Status report is not available. |
Codecov Report
@@ Coverage Diff @@
## development/8.1 #2179 +/- ##
================================================
Coverage 64.34% 64.34%
================================================
Files 210 210
Lines 16391 16394 +3
Branches 3320 3321 +1
================================================
+ Hits 10547 10549 +2
- Misses 5829 5830 +1
Partials 15 15
|
not sure what this brings: we want to use this mode, it should not be disabled, and is the default in the version of arsenal where you add it... |
@francoisferrand it is not clearly documented if the option is set to In some other places like here https://www.mongodb.com/docs/atlas/resilient-application/, they still use it. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
The link you mention indicates it is not needed anymore (which is a hint for "should not be used" or "is useless"); and looking at the (official) documentation [1] it is not present anymore, since 5.0 at least... [1] https://mongodb.github.io/node-mongodb-native/5.0/interfaces/MongoClientOptions.html |
Add an option to support and enable this feature, as it is not clear, depending on the driver version, if this flag defaults to true or not.