-
Notifications
You must be signed in to change notification settings - Fork 19
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support extracting the http scheme from the requests #2278
base: development/7.10
Are you sure you want to change the base?
Conversation
Needed to ensure we can apply the aws:SecureTransport S3 condition Issue: ARSN-456
Hello williamlardier,My role is to assist you with the merge of this Available options
Available commands
Status report is not available. |
/create_integration_branches |
Integration data createdI have created the integration data for the additional destination branches.
The following branches will NOT be impacted:
You can set option
The following options are set: create_integration_branches |
Waiting for approvalThe following approvals are needed before I can proceed with the merge:
The following options are set: create_integration_branches |
3756a70
to
b1c4292
Compare
History mismatchMerge commit #3756a7008743e4fe59f15d30e32a864b97f75657 on the integration branch It is likely due to a rebase of the branch Please use the The following options are set: create_integration_branches |
/reset |
Reset completeI have successfully deleted this pull request's integration branches. The following options are set: create_integration_branches |
ConflictA conflict has been raised during the creation of I have not created the integration branch. Here are the steps to resolve this conflict: $ git fetch
$ git checkout -B w/7.70/bugfix/ARSN-456 origin/development/7.70
$ git merge origin/bugfix/ARSN-456
$ # <intense conflict resolution>
$ git commit
$ git push -u origin w/7.70/bugfix/ARSN-456 The following options are set: create_integration_branches |
Currently, behind a proxy, we cannot detect the right scheme. Also, we use the
request.connection.encrypted
variable, that is (1) deprecated and (2) already removed since Node 16, so the whole thing end up being undefined.We introduce a proper function to detect that the scheme provided by the trusted header is http or https, or we dynamically detect if the socket is a TLS instance, and check if it's secure.