Skip to content

Commit

Permalink
fixup! Precreate DR kafka volume
Browse files Browse the repository at this point in the history
  • Loading branch information
rachedbenmustapha committed Aug 16, 2024
1 parent bab953a commit 619423d
Showing 1 changed file with 5 additions and 2 deletions.
7 changes: 5 additions & 2 deletions tests/ctst/steps/pra.ts
Original file line number Diff line number Diff line change
Expand Up @@ -49,14 +49,16 @@ interface DrState {
}

async function installPRA(world: Zenko, sinkS3Endpoint = 'http://s3.zenko.local') {
const kafkaExternalIpOption = !!world.parameters.KafkaExternalIps ?

Check failure on line 52 in tests/ctst/steps/pra.ts

View workflow job for this annotation

GitHub Actions / lint-and-build-ctst

Redundant double negation
{ kafkaExternalIps: world.parameters.KafkaExternalIps } :
{ kafkaExternalIpsDiscovery: true };

return world.zenkoDrCtl?.install({
sourceZenkoDrInstance: 'end2end-source',
sinkZenkoDrInstance: 'end2end-pra-sink',
kafkaPersistenceSize: '1Gi',
kafkaPersistenceStorageClassName: '-',
kafkaPersistenceSelector: 'app=kafka-dr-sink',
kafkaExternalIps: world.parameters.KafkaExternalIps,
kafkaExternalIpsDiscovery: !world.parameters.KafkaExternalIps,
locations: 'e2e-cold', // comma-separated list
s3Bucket: 'dump-db',
sinkZenkoInstance: 'end2end-pra',
Expand All @@ -65,6 +67,7 @@ async function installPRA(world: Zenko, sinkS3Endpoint = 'http://s3.zenko.local'
sourceZenkoNamespace: 'default',
sourceS3Endpoint: 'http://s3.zenko.local',
sinkS3Endpoint,
...kafkaExternalIpOption,
});
}

Expand Down

0 comments on commit 619423d

Please sign in to comment.