Skip to content

Commit

Permalink
no wait
Browse files Browse the repository at this point in the history
  • Loading branch information
KillianG committed Aug 19, 2024
1 parent d1c63a8 commit 6bc3fdf
Show file tree
Hide file tree
Showing 2 changed files with 7 additions and 7 deletions.
11 changes: 6 additions & 5 deletions tests/ctst/steps/dr/drctl.ts
Original file line number Diff line number Diff line change
Expand Up @@ -42,8 +42,6 @@ type InstallConfig = {
sinkSs3AccessKeyField?: string;
sinkS3SecretKeyField?: string;
sinkS3Region?: string;

wait?: boolean;
};

type BootstrapDumpConfig = {
Expand Down Expand Up @@ -171,8 +169,11 @@ export default class ZenkoDrctl {
this.world = world;
}

private async runCommand(action: string, params: string, throwOnError = false) {
const command = `/ctst/zenko-drctl ${action} ${params}`;
private async runCommand(action: string, params: string, throwOnError = false, wait?: boolean) {
let command = `/ctst/zenko-drctl ${action} ${params}`;
if (wait == false) {
command += ' --wait=false';
}
try {
this.world.logger.debug('running zenko-drctl command', { command });
const result = await util.promisify(exec)(command);
Expand All @@ -187,7 +188,7 @@ export default class ZenkoDrctl {
}
}

async install(config: InstallConfig) {
async install(config: InstallConfig, wait = true) {

Check warning on line 191 in tests/ctst/steps/dr/drctl.ts

View workflow job for this annotation

GitHub Actions / lint-and-build-ctst

'wait' is assigned a value but never used
return this.runCommand('install', this.paramToCli(config), true);
}

Expand Down
3 changes: 1 addition & 2 deletions tests/ctst/steps/pra.ts
Original file line number Diff line number Diff line change
Expand Up @@ -66,10 +66,9 @@ async function installPRA(world: Zenko, sinkS3Endpoint = 'http://s3.zenko.local'
sourceZenkoInstance: 'end2end',
sourceZenkoNamespace: 'default',
sourceS3Endpoint: 'http://s3.zenko.local',
wait: false,
sinkS3Endpoint,
...kafkaExternalIpOption,
});
}, false);
}

export function preparePRA(world: Zenko) {
Expand Down

0 comments on commit 6bc3fdf

Please sign in to comment.