Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support multiple kafkaClusters in kafka alerts #2124

Merged
merged 2 commits into from
Aug 15, 2024

Conversation

KillianG
Copy link
Contributor

@KillianG KillianG commented Aug 12, 2024

Issue: ZENKO-4857

@bert-e
Copy link
Contributor

bert-e commented Aug 12, 2024

Hello killiang,

My role is to assist you with the merge of this
pull request. Please type @bert-e help to get information
on this process, or consult the user documentation.

Available options
name description privileged authored
/after_pull_request Wait for the given pull request id to be merged before continuing with the current one.
/bypass_author_approval Bypass the pull request author's approval
/bypass_build_status Bypass the build and test status
/bypass_commit_size Bypass the check on the size of the changeset TBA
/bypass_incompatible_branch Bypass the check on the source branch prefix
/bypass_jira_check Bypass the Jira issue check
/bypass_peer_approval Bypass the pull request peers' approval
/bypass_leader_approval Bypass the pull request leaders' approval
/approve Instruct Bert-E that the author has approved the pull request. ✍️
/create_pull_requests Allow the creation of integration pull requests.
/create_integration_branches Allow the creation of integration branches.
/no_octopus Prevent Wall-E from doing any octopus merge and use multiple consecutive merge instead
/unanimity Change review acceptance criteria from one reviewer at least to all reviewers
/wait Instruct Bert-E not to run until further notice.
Available commands
name description privileged
/help Print Bert-E's manual in the pull request.
/status Print Bert-E's current status in the pull request TBA
/clear Remove all comments from Bert-E from the history TBA
/retry Re-start a fresh build TBA
/build Re-start a fresh build TBA
/force_reset Delete integration branches & pull requests, and restart merge process from the beginning.
/reset Try to remove integration branches unless there are commits on them which do not appear on the source branch.

Status report is not available.

@KillianG KillianG force-pushed the improvement/ZENKO-4857-alerts-for-dr-kafka branch from e7a4db8 to 35b73aa Compare August 12, 2024 14:59
@KillianG KillianG force-pushed the improvement/ZENKO-4857-alerts-for-dr-kafka branch 3 times, most recently from 18d4c2b to e8191d7 Compare August 13, 2024 12:34
@scality scality deleted a comment from bert-e Aug 13, 2024
@bert-e
Copy link
Contributor

bert-e commented Aug 13, 2024

Request integration branches

Waiting for integration branch creation to be requested by the user.

To request integration branches, please comment on this pull request with the following command:

/create_integration_branches

Alternatively, the /approve and /create_pull_requests commands will automatically
create the integration branches.

@KillianG
Copy link
Contributor Author

/create_integration_branches

@bert-e
Copy link
Contributor

bert-e commented Aug 13, 2024

Integration data created

I have created the integration data for the additional destination branches.

The following branches will NOT be impacted:

  • development/2.5

You can set option create_pull_requests if you need me to create
integration pull requests in addition to integration branches, with:

@bert-e create_pull_requests

The following options are set: create_integration_branches

@bert-e
Copy link
Contributor

bert-e commented Aug 13, 2024

Waiting for approval

The following approvals are needed before I can proceed with the merge:

  • the author

  • 2 peers

The following options are set: create_integration_branches

@francoisferrand francoisferrand force-pushed the improvement/ZENKO-4857-alerts-for-dr-kafka branch from e8191d7 to a03cc0e Compare August 14, 2024 06:26
@KillianG
Copy link
Contributor Author

/approve

@scality scality deleted a comment from bert-e Aug 14, 2024
@KillianG KillianG changed the title Support multiple service in kafka alerts Support multiple kafkaClusters in kafka alerts Aug 14, 2024
@francoisferrand francoisferrand force-pushed the improvement/ZENKO-4857-alerts-for-dr-kafka branch from a03cc0e to f2a476f Compare August 14, 2024 22:19
@scality scality deleted a comment from bert-e Aug 14, 2024
@scality scality deleted a comment from bert-e Aug 14, 2024
@bert-e
Copy link
Contributor

bert-e commented Aug 14, 2024

Build failed

The build for commit did not succeed in branch improvement/ZENKO-4857-alerts-for-dr-kafka.

The following options are set: approve, create_integration_branches

@bert-e
Copy link
Contributor

bert-e commented Aug 15, 2024

Build failed

The build for commit did not succeed in branch w/2.9/improvement/ZENKO-4857-alerts-for-dr-kafka.

The following options are set: approve, create_integration_branches

@bert-e
Copy link
Contributor

bert-e commented Aug 15, 2024

I have successfully merged the changeset of this pull request
into targetted development branches:

  • ✔️ development/2.6

  • ✔️ development/2.7

  • ✔️ development/2.8

  • ✔️ development/2.9

  • ✔️ development/2.10

The following branches have NOT changed:

  • development/2.5

Please check the status of the associated issue ZENKO-4857.

Goodbye killiang.

The following options are set: approve, create_integration_branches

@bert-e bert-e merged commit f2a476f into development/2.6 Aug 15, 2024
15 checks passed
@bert-e bert-e deleted the improvement/ZENKO-4857-alerts-for-dr-kafka branch August 15, 2024 06:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants