Improvement/bb 585 bump deps #2611
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files
@@ Coverage Diff @@
## improvement/BB-615-dependencies-bump #2611 +/- ##
=====================================================================
Coverage 71.12% 71.12%
=====================================================================
Files 201 201
Lines 13338 13338
=====================================================================
Hits 9487 9487
Misses 3841 3841
Partials 10 10
Flags with carried forward coverage won't be shown. Click here to find out more. |
benzekrimaha
force-pushed
the
improvement/BB-585-bump-deps
branch
2 times, most recently
from
c55e193 to
9b15fe7
Compare
benzekrimaha
force-pushed
the
improvement/BB-585-bump-deps
branch
from
9b15fe7 to
ab81bc9
Compare
| @@ -26,6 +26,14 @@ jobs: | |||
| registry: ghcr.io | |||
| username: ${{ github.repository_owner }} | |||
| password: ${{ github.token }} | |||
|
|
|||
| - name: Install Oras | |||
There was a problem hiding this comment.
fix already merged
| @@ -196,7 +196,7 @@ jobs: | |||
| token: ${{ secrets.CODECOV_TOKEN }} | |||
|
|
|||
| - name: run ballooning tests for lifecycle conductor | |||
| run: yarn mocha tests/performance/lifecycle/conductor-check-memory-balloon.js | |||
| run: yarn mocha tests/performance/lifecycle/conductor-check-memory-balloon.js --exit | |||
There was a problem hiding this comment.
the --exit flag is not recomended by mocha :
TL;DR: If your tests hang after an upgrade to Mocha v4.0.0 or newer, use --exit for a quick (though not necessarily recommended) fix.
Prior to version v4.0.0, by default, Mocha would force its own process to exit once it was finished executing all tests. This behavior enables a set of potential problems; it’s indicative of tests (or fixtures, harnesses, code under test, etc.) which don’t clean up after themselves properly. Ultimately, “dirty” tests can (but not always) lead to false positive or false negative results.
“Hanging” most often manifests itself if a server is still listening on a port, or a socket is still open, etc. It can also be something like a runaway setInterval(), or even an errant Promise that never fulfilled.
The default behavior in v4.0.0 (and newer) is --no-exit, where previously it was --exit.
The easiest way to “fix” the issue is to pass --exit to the Mocha process. It can be time-consuming to debug — because it’s not always obvious where the problem is — but it is recommended to do so.
- why do we need to add it?
- if we don't know why (and don't have the time to debug or prefer to merge this 'large' PR first to avoid more conflicts/...), then we must create a ticket already so we do a better fix ASAP.
| @@ -1,6 +1,7 @@ | |||
| # Zenko Backbeat | |||
|
|
|||
|  | |||
| [![Build Status][badgepriv]][badgepub] | |||
There was a problem hiding this comment.
these badge are not correct, the URLs (at the end of this file) should be updated
| @@ -17,17 +17,17 @@ | |||
| "oplog_populator": "node extensions/oplogPopulator/OplogPopulatorTask.js", | |||
| "mongo_queue_processor": "node extensions/mongoProcessor/mongoProcessorTask.js", | |||
| "garbage_collector": "node extensions/gc/service.js", | |||
| "test": "mocha --recursive tests/unit --timeout 30000", | |||
| "test": "mocha --recursive tests/unit --timeout 30000 --exit", | |||
There was a problem hiding this comment.
same, it is recommneded not to use the flag, and fix the test(s) that need it...
| if (a.VersionId < b.VersionId) {return -1;} | ||
| if (a.VersionId > b.VersionId) {return 1;} | ||
| return 0; |
There was a problem hiding this comment.
| if (a.VersionId < b.VersionId) {return -1;} | |
| if (a.VersionId > b.VersionId) {return 1;} | |
| return 0; | |
| if (a.VersionId < b.VersionId) { | |
| return -1; | |
| } | |
| if (a.VersionId > b.VersionId) { | |
| return 1; | |
| } | |
| return 0; |
| @@ -1,4 +1,4 @@ | |||
| 'use strict'; // eslint-disable-line | |||
| 'use strict'; | |||
There was a problem hiding this comment.
extra spaces at end of line (in many files actually)
| 'use strict'; | |
| 'use strict'; |
| @@ -1,4 +1,4 @@ | |||
| 'use strict'; // eslint-disable-line | |||
| 'use strict'; | |||
There was a problem hiding this comment.
extra spaces at end of line
| @@ -19,14 +19,13 @@ jobs: | |||
| - name: Checkout | |||
| uses: actions/checkout@v4 | |||
|
|
|||
| # TODO: remove the following step once Oras CLI 0.13.0 bug https://github.com/oras-project/oras/issues/447 is fixed. | |||
| - name: Downgrade Oras to 0.12.0 | |||
| - name: Install Oras | |||
There was a problem hiding this comment.
fix already merged
Issue: BB-585